Dev #1
Open
Dev #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 2, 2021 12:33
airtonix
reviewed
May 2, 2021
| @@ -0,0 +1,2 @@ | |||
| node_module | |||
There was a problem hiding this comment.
this should be node_modules
Suggested change
| node_module | |
| node_modules | |
| @@ -1,24 +1,29 @@ | |||
| const crypto = require('crypto'); | |||
| const https = require('https'); | |||
| require('dotenv').config(); | |||
There was a problem hiding this comment.
Suggested change
| require('dotenv').config(); | |
| const nconf = require('nconf'); |
Comment on lines
+5
to
+6
| const apiKey = process.env.API_KEY; | ||
| const privateKey = process.env.PRIVATE_KEY; |
There was a problem hiding this comment.
I would suggest using nconf over dotenv, it's far more "12 factor" and a better user experience.
Suggested change
| const apiKey = process.env.API_KEY; | |
| const privateKey = process.env.PRIVATE_KEY; | |
| const ENV_SEPARATOR = '__'; | |
| const KEY = 'btcmarkets'; | |
| const ENV_PATTERN = new RegExp(`/^${KEY.toUpperCase()}${ENV_SEPARATOR}/`); | |
| nconf | |
| .env({ | |
| separator: ENV_SEPARATOR, | |
| match: ENV_PATTERN, | |
| lowerCase: true, | |
| parseValues: true, | |
| transform(obj) { | |
| obj.key.replace(ENV_PATTERN, ''); | |
| return obj; | |
| }, | |
| }) | |
| .argv({ | |
| apiKey: { | |
| describe: 'prefix of all new packages created', | |
| }, | |
| privateKey: { | |
| describe: 'prefix of all new packages created', | |
| } | |
| }); | |
| const apiKey = nconf.get('apiKey'); | |
| const privateKey = nconf.get('privateKey'); |
Now the cli is used like this:
node client.js --apiKey=something --privateKey=another-thingor
BTCMARKETS_API_KEY=something \
BTCMARKETS_API_PRIVATE=another-thing \
node client.js you'll also get :
node client.js --help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.